Fix broken RSS links #206
Merged
Fix broken RSS links #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trac itself uses `referer`, so this change makes it easier to integrate with some other Trac functionalities.
Closed
bmispelon
force-pushed
the
issue/204-fix-rss-links
branch
from
bdedc19 to
b151f81
Compare
bmispelon
force-pushed
the
issue/204-fix-rss-links
branch
from
b151f81 to
d2d3f11
Compare
|
This is clever! (Sometimes it really is better to fix the symptom than the cause.) Is there already a test to ensure "referer" can't be used as an open redirect exploit? |
Member
Author
Very good question, thanks for thinking about that. We do have a test that should cover everything: If you can think of a corner-case that's not covered by that test, please send a PR ( |
Member
Author
|
(the fix should be live, let me know how it goes) |
|
Much better. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204